Fix default updaters bug in GeographicPartition #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InnovativeInventor
force-pushed
the
fix-default-updaters-bug
branch
from
e78a155
to
2638415
Compare
Codecov Report
@@ Coverage Diff @@
## main #391 +/- ##
=======================================
Coverage 87.83% 87.84%
=======================================
Files 37 37
Lines 1735 1736 +1
=======================================
+ Hits 1524 1525 +1
Misses 211 211
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several GerryChain users have been reporting a bug in the most recent version of GerryChain where the default updaters in a
GeographicPartition(e.g.area,boundary_nodes, etc.) are not being instantiated properly. This PR fixes the bug and adds regression tests to ensure that this doesn't happen again.It also renames the
use_cut_edgesflag touse_default_updaters, which more accurately reflects its intended purpose.