Add seed and freeze test to loudly detect when breaking changes are made #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If anyone's watching this PR and is curious about the list of commits that changed GerryChain outputs (and were flagged for careful correctness review), here it is: 456eddc Note that a fair number of these commits appear to be correct. However, they're totally worth a second look. |
Codecov Report
@@ Coverage Diff @@
## main #378 +/- ##
==========================================
+ Coverage 87.89% 88.19% +0.30%
==========================================
Files 37 37
Lines 1660 1660
==========================================
+ Hits 1459 1464 +5
+ Misses 201 196 -5
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, I flagged a few historical commits that unintentionally produce different chain outputs (with the same seed, etc). This is concerning (since it could mean that correctness issues were introduced in those commits). This PR adds a "seed and freeze" test to loudly detect such changes.