Parse Spells #152
Merged
Parse Spells #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Small /introduce parser fix too, there's an extra space in there
mgeitz
force-pushed
the
feature/abra-kadabra
branch
from
8e9a1f1 to
1a9bc2f
Compare
added 3 commits
June 10, 2022 23:29
- Useful for creating spell text matches, probably going to ignore everything under other but wanted to ensure this util script would default to take everything from the txt file - Cut down spells_us.json generation to just the essentials by default. Otherwise its nearly a half-million mostly not useful lines. Uncomment accordingly for any other needs. - Keeping seconds to work with here, not ticks
- Re-order config into separate files - One caveat with this, the list of line alerts in settings tab is unordered
- Renames a few paths in settings.json - Adds path to locate spells_us.txt - Generate data/spell-timers.json from spells_us.txt
mgeitz
force-pushed
the
feature/abra-kadabra
branch
from
1a9bc2f to
a8f502e
Compare
- version the spells_us file generation because I don't know if more needs to be added to it - /say parser what context, report context - prepare for the grind
mgeitz
force-pushed
the
feature/abra-kadabra
branch
from
0c53aed to
eccd448
Compare
added 20 commits
June 13, 2022 17:35
- Fixed add_type issue - Finished 'a' spells - finished 'b' spells - About 10% through the spell text matching. Planning to do another pass to generalize the returns on shared spell text, for now the first spell match I wrote for that text is returned
- All spells starting with c and d
- Check spell specific is way too big and definitely will need to be split up
- Such a mess of elif my linter hits a recursion error
- I feel irresponsible putting this many elif statements into the world
- When I started this I knew there was a lot of spell text, but this is a _lot_ of spell text
Next up: - Remove duplicates - Correct returns for all matches associated to multiple spells - Organize matches to group broad similarities to cut down on undetermined checks (starts with you, starts with your, etc) - Add config entries - Set default config values covering typical raid alerts - Increment version
added 5 commits
June 19, 2022 15:21
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This brings the
config.jsonfile into very questionable length territory - my current config is already 2,156 lines long and this feature apparently adds 8,076 x 3 line types to that. The x3 is to account for the different sources or targets: you/you, you/other, other/other, I think you/you captures other/you here. This would amount to an additional 121,140 lines to theconfig.jsonwith default line_type settings.Should the configuration for line alert be restructured into different files or directories?
Or is ctrl+f in one absurdly huge config file all thats needed?
I'm going to try splitting it up, this will also save character data from config changes, I don't think there's any other char data worth collecting to add to it.
config.jsonspells_us.txtto something marginally more usefulResolves #149
Resolves #157
Resolves #158
Resolves #52 (I think this could have been resolved ages ago)
Partially resolves #85 (step 2)