Skip to content

fix(rule): 'contextual-decorator' - decorators with arguments, accessors and some missing decorators not being handled #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mgechev merged 1 commit into from
May 1, 2019
Merged

fix(rule): 'contextual-decorator' - decorators with arguments, accessors and some missing decorators not being handled #798

mgechev merged 1 commit into from
May 1, 2019

Conversation

@rafaelss95
Copy link
Collaborator

@rafaelss95 rafaelss95 commented Mar 24, 2019 •
edited
Loading

This:

  • Fixes a bug introduced in the new version; (Currently it's not reporting failures if the decorator has arguments due to

    codelyzer/src/contextualDecoratorRule.ts

    Line 66 in c07ac5e

    .map(x => x.replace(/[^a-zA-Z]/g, ''))
  • Reports failures for accessors with decorators (ex. @Input, @ViewChild);
  • Reports failures for parameter properties decorators (ex. @Attribute, @Host, etc...);

Fixes #776.

@rafaelss95
Copy link
Collaborator Author

rafaelss95 commented Mar 24, 2019 •
edited
Loading

I've added the blocked label until the #797 gets in.

@rafaelss95 rafaelss95 marked this pull request as ready for review April 14, 2019 18:48
@rafaelss95 rafaelss95 requested review from mgechev and wKoza April 14, 2019 19:03
mgechev
mgechev reviewed Apr 29, 2019
View reviewed changes
test/contextualDecoratorRule.spec.ts Outdated
} = Rule;

describe(ruleName, () => {
describe.only(ruleName, () => {
Copy link
Owner

@mgechev mgechev Apr 29, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you drop the .only part

Copy link
Collaborator Author

@rafaelss95 rafaelss95 Apr 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@rafaelss95
fix(rule): 'contextual-decorator' - decorators with arguments, access…
8ba861c 
…ors and some missing decorators not being handled
@mgechev mgechev merged commit efbcb69 into mgechev:master May 1, 2019
@rafaelss95 rafaelss95 deleted the refactor/contextual-decorator branch August 17, 2019 22:44
@snyk-bot snyk-bot mentioned this pull request Mar 12, 2020
Closed
@snyk-bot snyk-bot mentioned this pull request Apr 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgechev mgechev mgechev approved these changes

@wKoza wKoza Awaiting requested review from wKoza

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

contextual-decorator: fails for some cases

2 participants

@rafaelss95 @mgechev