-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i18n best practices #377
Comments
Would it be possible to also add a rule that looks for elements in component templates that have text content but no i18n attribute? One issue we are having on our team is simply enforcing that people mark all the exposed strings for extraction and translation. |
This should be relatively straightforward. I will add it as part of this issue. |
@mgechev Awesome. Thanks!!! |
@abierbaum both rules are implemented in #386. Should be ready to use in codelyzer@3.2.0. |
In general, I would not recommend overriding the auto-generated ID. In a project that have thousands of strings to be translated, it is error prone to rely on the developer to ensure that the ID is unique across the entire application. |
@mgechev Thanks for adding this!!! |
Consider to add the following i18n best practice:
https://angular.io/guide/i18n#set-a-custom-id-to-improve-search-and-maintenance
The text was updated successfully, but these errors were encountered: