Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for tslint^5 #281

Closed
mgechev opened this issue Mar 31, 2017 · 9 comments
Closed

Support for tslint^5 #281

mgechev opened this issue Mar 31, 2017 · 9 comments
Assignees
@mgechev
Labels
enhancement P1
Milestone
3.0.0 - Lamido

Comments

@mgechev
Copy link
Owner

mgechev commented Mar 31, 2017

No description provided.

@mgechev mgechev added this to the 3.0.0-beta.5 - Magouliana milestone Mar 31, 2017
@jskrzypek
Copy link

Fwiw, I've started taking a stab at refactoring some of the rules to be compatible with tslint^5
It's currently on my branch here: https://github.com/jskrzypek/codelyzer/tree/feat/tslint-5

Let me know if I should make a PR now or wait till this is more mature

@mgechev
Copy link
Owner Author

mgechev commented Apr 6, 2017

Thanks for the help! PR sounds good. We should think how to release them. Probably introducing codelyzer@3.0.0 and pushing the features in the current 3.0.0 branches to 4.0.0 sounds reasonable.
Let me sync with the Angular CLI guys before we go any further.

@jskrzypek
Copy link

jskrzypek commented Apr 6, 2017 •
edited
Loading

I'll massage the commit based on @ajafff's comments (links below) and make a PR later today

@clydin clydin mentioned this issue Apr 12, 2017
Merged
AdamJo added a commit to AdamJo/dota2-minimap-spectator that referenced this issue Apr 13, 2017
@AdamJo
fix(travis)
43376d6 
did not watch out for my previous mistake with tslint.
mgechev/codelyzer#281
Will be updated in codelyzer in 3.0.0
@mgechev mgechev mentioned this issue Apr 13, 2017
Closed
@jvbianchi
Copy link

tslint v5.1.0 was released.

Will you support this version too?

@Nolanus Nolanus mentioned this issue Apr 19, 2017
Closed
@mgechev
Copy link
Owner Author

mgechev commented Apr 19, 2017

Since it's a minor release, in case we support 5.0.0 we'll automatically have support for 5.1.0.

Over the weekend I'll work on the migration to version 5 and open a PR in the CLI once done.

@mgechev
Copy link
Owner Author

mgechev commented Apr 20, 2017

The support for tslint@5 just landed in master. I'll publish a new release over the weekend.

@mgechev mgechev self-assigned this Apr 20, 2017
@mgechev
Copy link
Owner Author

mgechev commented Apr 22, 2017

Closing the issue. 3.0.0 should be available tomorrow, followed by PR to the CLI.

@mgechev mgechev closed this as completed Apr 22, 2017
@mgechev
Copy link
Owner Author

mgechev commented Apr 23, 2017

Codelyzer 3.0.0 is published https://www.npmjs.com/package/codelyzer.

@cexbrayat
Copy link
Contributor

@mgechev Thank you for this!

PR for the CLI pending for review angular/angular-cli#6058

filipesilva pushed a commit to angular/angular-cli that referenced this issue May 4, 2017
@clydin @filipesilva
test: update development tslint version (#5936)
de8336d 
Also fixes any encountered errors.

This only changes the version used for the CLI's development.  The project template version of tslint cannot be updated until codelyzer supports the latest version. ([codelyzer tracking issue](mgechev/codelyzer#281))
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this issue Apr 23, 2018
@clydin @dond2clouds
test: update development tslint version (angular#5936)
8c69ce6 
Also fixes any encountered errors.

This only changes the version used for the CLI's development.  The project template version of tslint cannot be updated until codelyzer supports the latest version. ([codelyzer tracking issue](mgechev/codelyzer#281))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgechev mgechev

Labels
enhancement P1
Projects
None yet
Milestone
3.0.0 - Lamido
Development

No branches or pull requests
4 participants
@cexbrayat @mgechev @jskrzypek @jvbianchi