New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rule "templates-use-public" does not correctly distinguish public from private members #206

Closed

marco-eckstein opened this issue Dec 26, 2016 · 1 comment

marco-eckstein commented Dec 26, 2016

There is a bug in rule "templates-use-public": If only modifier "readonly" is present, a member is public, but the rule considers it private.

Tested with 2.0.0-beta.3.

Owner

mgechev commented Dec 26, 2016

Thanks for reporting the issue! I will introduce a fix in the next release.

mgechev added a commit that referenced this issue


          fix: proper check for public members

3e6a125

Fix #206

mgechev added a commit that referenced this issue


          fix: proper check for public members

cc3ed9a

Fix #206

mgechev mentioned this issue

fix: proper check for public members #209

Merged

mgechev closed this as completed in #209

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment