Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on @Pipe decorator #111

Closed
aitboudad opened this issue Oct 11, 2016 · 4 comments
Closed

Error on @Pipe decorator #111

aitboudad opened this issue Oct 11, 2016 · 4 comments
Assignees
@mgechev
Labels
bug P2
Milestone
Beta 5 - Trichoco...

Comments

@aitboudad
Copy link 

@Pipe
export class Foo implements PipeTransform {}
TypeError: Cannot read property 'text' of undefined
    at node_modules/codelyzer/pipeNamingRule.js:52:39
@preslavsh
Copy link
Collaborator

This error occurs from lack of metadata.

@mgechev
Copy link
Owner

mgechev commented Oct 11, 2016

I will take this issue, we had it some time in the past for components.

@mgechev mgechev self-assigned this Oct 11, 2016
@mgechev mgechev added this to the Beta 2 - Trichocolea mollissima milestone Oct 11, 2016
mgechev added a commit that referenced this issue Oct 11, 2016
@mgechev
fix(pipeNaming): do not fail on empty @pipe decorator
eb6ccc0 
Add `visitNg2Pipe` method in `NgwWalker`.
Refactor pipe related rules to use `Ng2Walker`.

Fix #111
@mgechev mgechev mentioned this issue Oct 11, 2016
Closed
@mgechev
Copy link
Owner

mgechev commented Oct 11, 2016

@aitboudad in the next a couple of days the fix will be in master and after that we'll push it to npm.

@aitboudad
Copy link
Author

awesome! thanks ;)

mgechev added a commit that referenced this issue Oct 12, 2016
@mgechev
fix(pipeNaming): do not fail on empty @pipe decorator
e2e08a8 
Add `visitNg2Pipe` method in `NgwWalker`.
Refactor pipe related rules to use `Ng2Walker`.

Fix #111
mgechev added a commit that referenced this issue Oct 12, 2016
@mgechev
fix(pipeNaming): do not fail on empty @pipe decorator
623c43f 
Add `visitNg2Pipe` method in `NgwWalker`.
Refactor pipe related rules to use `Ng2Walker`.

Fix #111
@mgechev mgechev mentioned this issue Oct 13, 2016
Merged
@leonadler leonadler mentioned this issue Aug 28, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgechev mgechev

Labels
bug P2
Projects
None yet
Milestone
Beta 5 - Trichocolea mollissima
Development

No branches or pull requests
3 participants
@mgechev @aitboudad @preslavsh