Qt: handle newlines in TextBuffer print() #3314
Open
+19
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahigerd
force-pushed
the
alh/text-buffer-newlines
branch
from
bfec8cc
to
51718b1
Compare
ahigerd
changed the title
endrift
reviewed
Oct 12, 2024
| if (!m_shim.cursor.atBlockEnd()) { | ||
| m_shim.cursor.movePosition(QTextCursor::EndOfBlock, QTextCursor::KeepAnchor); | ||
| for (QString split : text.split('\n')) { | ||
| m_shim.cursor.beginEditBlock(); |
There was a problem hiding this comment.
Shouldn't this be outside the loop?
There was a problem hiding this comment.
I don't think so? We want to create a new block for each line being inserted, don't we?
There was a problem hiding this comment.
Hm. Actually, reading the docs, why do you even need this? You don't support undo/redo in text buffers and that's all this does.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User "Wombat" observed that printing strings containing newlines into a text buffer would word-wrap as if the newlines weren't there. Turns out, ScriptingTextBuffer::print() just wasn't handling newlines at all. This PR causes print() to split the input on newlines and add each section as a separate line in the document.