Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red border in minimized WebDockableFrame #596

Closed
husker-dev opened this issue Dec 6, 2019 · 1 comment
Closed

Red border in minimized WebDockableFrame #596

husker-dev opened this issue Dec 6, 2019 · 1 comment
Assignees

Comments

@husker-dev
Copy link

Why do I have red border in a minimized WebDockableFrame? It became with WebLaF 1.2.11.

WebLaF 1.2.10

image

WebLaF 1.2.11

image

@mgarin mgarin self-assigned this Dec 6, 2019
@mgarin mgarin added this to the v1.2.12 milestone Dec 6, 2019
mgarin added a commit that referenced this issue Dec 6, 2019
- dockableframe.xml - Fixed base style border color for the sidebar button [ #596 ]
@mgarin
Copy link
Owner

mgarin commented Dec 6, 2019

That is a bug, seems that I've accidentally replaced the border color in the base skin.
I've pushed a fix for it, it will be available in the v1.2.12 snapshot version shortly.

I'll also add a few dockable examples into demo later on to make sure I won't miss out on the visual issues in future updates. I've missed it because at this point I'm using StyleId.dockablepaneCompact and StyleId.dockableframeCompact styles for all dockable elements and those didn't have the same problem.

So there are a few options to solve this problem (until v1.2.12 release):

  • Use custom skin with the border replaced in default style
  • Use custom style for WebDockableFrame with the border replaced
  • Use v1.2.12 snapshot version with the fix
  • Use StyleId.dockableframeCompact (you might also like this one more)

I'm planning to switch to different versioning approach to easily release hotfixes like this one fast, but for now, unfortunately, next update will take some time.

@mgarin mgarin closed this as completed Dec 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants