WebPopup setCloseOnFocusLoss doesn't work

[renato]

The closeOnFocusLoss property on WebPopup is ignored because the ShadeLayer has its own way to hideAllPopups: the blockClose property, which is inaccessible without manually instantiating a ShadeLayer and doing what PopupManager does.

My nasty workaround for a real modal WebPopup:

Method method = PopupManager.class.getDeclaredMethod("getShadeLayer", JRootPane.class);
method.setAccessible(true);
((ShadeLayer)method.invoke(null, rootPane)).setBlockClose(true);

[mgarin]

Good point.

I guess I will add three options:

1. Public access to PopupManager.getShadeLayer () - no idea why I made it private
2. New webPopup.getPopupLayer () method in WebPopup to retrieve layer it uses
3. Add blockClose argument into PopupManager.showModalPopup () methods
   I will include those changes into v1.28 update.

And generally - I am trying to do make WebLaF code developer-friendly, so you would be able to access/override/improve as much things as there are available in the library. So if you find any other issues in WebLaF which force your code to be inconvenient - just notify me and I will deal with it :) That also includes any missing methods you might want to see in components and such.

[mgarin]

By the way - if you like to use Reflection from time to time - ReflectUtils might be really useful for you.
For example the code you used to call hidden method could be converted to this:

final ShadeLayer layer = ReflectUtils.callStaticMethodSafely ( PopupManager.class, "getShadeLayer" );
layer.setBlockClose ( true );

This won't even require any try-catch blocks. And yes, it always makes the method accessible.
But that is just a small note :)

[renato]

I need reflection more than I like it, but it's good to be aware of ReflectUtils.

Thank you. :)

[renato]

One more thing... the callStaticMethodSafely() doesn't work here because the getMethods() on ReflectUtils.java:859 returns only the public methods. The private methods are accessible only with getDeclaredMethods().

[mgarin]

Nice one, it is actually a bug. If you look further into a similar method callMethod (ReflectUtils.java:1050) - it calls exactly the getDeclaredMethods instead of getMethods. I was fixing it and didn't notice that the static version still have the old method used.

Thanks for noting this one :)

[mgarin]

Why I have created methods like ReflectUtils.callMethod in the first place is that Class.getMethod(String, Class...) doesn't work the way I want it to.

For example if you have a class with method:

public class MyClass 
{
    public void doSomething ( Object object )
    {
        //
    }
}

And you will try to find it using non-object class type:

myClass.getMethod ( "doSomething", String.class )

You will simply find nothing since you have to provide exact method argument type, supertypes simply won't work. Here is the only way it will work:

myClass.getMethod ( "doSomething", Object.class )

And basically the same applies to constructors.
Well, I guess you might know about this unpleasant thing.

[mgarin]

I have committed all of the changes, you can build temporary library version from sources if you want to test it out right away or wait for v1.28 release which will include it.

[mgarin]

Changes are now available in v1.28 update:
https://github.com/mgarin/weblaf/releases/tag/v1.28