Turn off debugging tools for release builds (facebook#664)

* turn off debugging tools for release builds * UIColor -> RCTUIColor build break fix * verdaccio host connection refused (facebook#665) * verdaccio host connection refused * listen to all ports * update localhost server * disable waiting step * master to 62 * node setup * more verdaccio fixes * turn off debugging tools for release builds * UIColor -> RCTUIColor build break fix
mganandraj · Dec 4, 2020 · 03de3d7 · 03de3d7
1 parent 5cb20c0
commit 03de3d7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/React/Base/RCTDefines.h b/React/Base/RCTDefines.h
@@ -43,7 +43,8 @@
 #define RCT_DEV 1
 #else
 // Dev Mode is now enabled or disabled at runtime via the -[RCTDevSettings isDevModeEnabled] property
-#define RCT_DEV 1
+// For now, disable debugging in release builds to avoid a bug where we can Redbox in module init
+#define RCT_DEV 0
 #endif
 #endif
 

diff --git a/React/DevSupport/RCTDevLoadingView.m b/React/DevSupport/RCTDevLoadingView.m
@@ -210,7 +210,7 @@ @implementation RCTDevLoadingView
 
 + (NSString *)moduleName { return nil; }
 + (void)setEnabled:(BOOL)enabled { }
-- (void)showMessage:(NSString *)message color:(UIColor *)color backgroundColor:(UIColor *)backgroundColor { }
+- (void)showMessage:(NSString *)message color:(RCTUIColor *)color backgroundColor:(RCTUIColor *)backgroundColor { }
 - (void)showWithURL:(NSURL *)URL { }
 - (void)updateProgress:(RCTLoadingProgress *)progress { }
 - (void)hide { }