Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overloaded methods to create tables/indexes without specifying zero #531

Merged
merged 14 commits into from
Dec 8, 2024
Merged

Add overloaded methods to create tables/indexes without specifying zero #531

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
ead152f
Creation of Table with zero size
mfvanek Dec 7, 2024
afcf90c
Creation of Indexes with zero size
mfvanek Dec 7, 2024
e0c3253
Add javadoc
mfvanek Dec 7, 2024
2d538e4
Add additional constructors to the Table
mfvanek Dec 7, 2024
0c7749f
Add additional constructors to the TableWithBloat and TableWithMissin…
mfvanek Dec 7, 2024
4efa26a
Add additional constructors to the SequenceState
mfvanek Dec 8, 2024
8ebf69a
Add additional constructors to the StoredFunction
mfvanek Dec 8, 2024
e8620e3
Add additional constructors to the Index and IndexWithBloat
mfvanek Dec 8, 2024
a496aab
Add additional constructors to the IndexWithColumns and Column
mfvanek Dec 8, 2024
8e4fedb
Add additional constructors to the IndexWithNulls
mfvanek Dec 8, 2024
64d4fc7
Add additional constructors to the IndexWithSize
mfvanek Dec 8, 2024
c7db6f9
Add additional constructors to the UnusedIndex
mfvanek Dec 8, 2024
1db5995
Add additional constructors to the IndexWithBloat and TableWithBloat
mfvanek Dec 8, 2024
ff072fb
Add additional constructors to the Constraint
mfvanek Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Creation of Indexes with zero size
  • Loading branch information
@mfvanek
mfvanek committed Dec 7, 2024
commit afcf90cbe605a822ef93418035e16cc6db3e0398
4 changes: 2 additions & 2 deletions ...src/test/java/io/github/mfvanek/pg/core/checks/host/DuplicatedIndexesCheckOnHostTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ void onDatabaseWithThem(final String schemaName) {
.hasSize(1)
.containsExactly(
DuplicatedIndexes.of(
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("accounts_account_number_key"), 0L),
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number"), 0L)))
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("accounts_account_number_key")),
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number"))))
.allMatch(d -> d.getTotalSize() >= 16_384L);

assertThat(check)
Expand Down
12 changes: 6 additions & 6 deletions ...rc/test/java/io/github/mfvanek/pg/core/checks/host/IntersectedIndexesCheckOnHostTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,12 +48,12 @@ void onDatabaseWithThem(final String schemaName) {
.hasSize(2)
.containsExactly(
DuplicatedIndexes.of(
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number_not_deleted"), 0L),
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_number_balance_not_deleted"), 0L)
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number_not_deleted")),
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_number_balance_not_deleted"))
),
DuplicatedIndexes.of(
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first"), 0L),
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"), 0L)))
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first")),
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"))))
.allMatch(d -> d.getTotalSize() >= 106_496L);

assertThat(check)
Expand All @@ -75,8 +75,8 @@ void shouldFindHashIndex(final String schemaName) {
.hasSize(1)
.containsExactly(
DuplicatedIndexes.of(
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first"), 0L),
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"), 0L)))
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first")),
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"))))
.allMatch(d -> d.getTotalSize() >= 106_496L);

assertThat(check)
Expand Down
12 changes: 6 additions & 6 deletions ...ore/src/test/java/io/github/mfvanek/pg/core/checks/host/UnusedIndexesCheckOnHostTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ void onDatabaseWithThem(final String schemaName) {
.executing(ctx)
.hasSize(6)
.containsExactlyInAnyOrder(
UnusedIndex.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_number_balance_not_deleted"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number_not_deleted"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_id_account_number_not_deleted"), 0L, 0))
UnusedIndex.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first")),
UnusedIndex.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name")),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number")),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_number_balance_not_deleted")),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number_not_deleted")),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_id_account_number_not_deleted")))
.allMatch(i -> i.getIndexSizeInBytes() > 0L)
.allMatch(i -> i.getIndexScans() == 0);

Expand Down
14 changes: 14 additions & 0 deletions pg-index-health-model/src/main/java/io/github/mfvanek/pg/model/index/IndexWithSize.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,4 +81,18 @@ public static IndexWithSize of(@Nonnull final String tableName,
final long indexSizeInBytes) {
return new IndexWithSize(tableName, indexName, indexSizeInBytes);
}

/**
* Constructs an {@code IndexWithSize} object with zero size.
*
* @param tableName table name; should be non-blank.
* @param indexName index name; should be non-blank.
* @return {@code IndexWithSize}
* @since 0.14.3
*/
@Nonnull
public static IndexWithSize of(@Nonnull final String tableName,
@Nonnull final String indexName) {
return new IndexWithSize(tableName, indexName, 0L);
}
}
14 changes: 14 additions & 0 deletions pg-index-health-model/src/main/java/io/github/mfvanek/pg/model/index/UnusedIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,24 @@ public String toString() {
* @throws NullPointerException if {@code tableName} or {@code indexName} is null
* @throws IllegalArgumentException if {@code indexScans} is negative
*/
@Nonnull
public static UnusedIndex of(@Nonnull final String tableName,
@Nonnull final String indexName,
final long indexSizeInBytes,
final long indexScans) {
return new UnusedIndex(tableName, indexName, indexSizeInBytes, indexScans);
}

/**
* Creates a new {@code UnusedIndex} instance with zero size.
*
* @param tableName the name of the table associated with the index, must be non-null
* @param indexName the name of the index, must be non-null
* @return a new {@code UnusedIndex} instance
*/
@Nonnull
public static UnusedIndex of(@Nonnull final String tableName,
@Nonnull final String indexName) {
return new UnusedIndex(tableName, indexName, 0L, 0L);
}
}
2 changes: 2 additions & 0 deletions pg-index-health-model/src/main/java/io/github/mfvanek/pg/model/table/Table.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,10 @@ public static Table of(@Nonnull final String tableName, final long tableSizeInBy

/**
* Constructs a {@code Table} object with zero size.
*
* @param tableName table name; should be non-blank.
* @return {@code Table}
* @since 0.14.3
*/
@Nonnull
public static Table of(@Nonnull final String tableName) {
Expand Down
2 changes: 1 addition & 1 deletion pg-index-health-model/src/test/java/io/github/mfvanek/pg/model/index/IndexWithSizeTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class IndexWithSizeTest {

@Test
void indexWithZeroSize() {
final IndexWithSize index = IndexWithSize.of("t", "i", 0L);
final IndexWithSize index = IndexWithSize.of("t", "i");
assertThat(index.getIndexName())
.isEqualTo("i")
.isEqualTo(index.getName());
Expand Down
3 changes: 3 additions & 0 deletions pg-index-health-model/src/test/java/io/github/mfvanek/pg/model/index/UnusedIndexTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ void getIndexScans() {
void testToString() {
assertThat(UnusedIndex.of("t", "i", 1L, 2L))
.hasToString("UnusedIndex{tableName='t', indexName='i', " + "indexSizeInBytes=1, indexScans=2}");

assertThat(UnusedIndex.of("t", "i"))
.hasToString("UnusedIndex{tableName='t', indexName='i', " + "indexSizeInBytes=0, indexScans=0}");
}

@Test
Expand Down
4 changes: 2 additions & 2 deletions .../java/io/github/mfvanek/pg/health/checks/cluster/DuplicatedIndexesCheckOnClusterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ void onDatabaseWithThem(final String schemaName) {
.hasSize(1)
.containsExactly(
DuplicatedIndexes.of(
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("accounts_account_number_key"), 0L),
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number"), 0L)))
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("accounts_account_number_key")),
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number"))))
.allMatch(d -> d.getTotalSize() >= 16_384L);

assertThat(check)
Expand Down
12 changes: 6 additions & 6 deletions ...java/io/github/mfvanek/pg/health/checks/cluster/IntersectedIndexesCheckOnClusterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,12 +47,12 @@ void onDatabaseWithThem(final String schemaName) {
.hasSize(2)
.containsExactly(
DuplicatedIndexes.of(
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number_not_deleted"), 0L),
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_number_balance_not_deleted"), 0L)
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number_not_deleted")),
IndexWithSize.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_number_balance_not_deleted"))
),
DuplicatedIndexes.of(
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first"), 0L),
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"), 0L)))
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first")),
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"))))
.allMatch(d -> d.getTotalSize() >= 106_496L);

assertThat(check)
Expand All @@ -74,8 +74,8 @@ void shouldFindHashIndex(final String schemaName) {
.hasSize(1)
.containsExactly(
DuplicatedIndexes.of(
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first"), 0L),
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"), 0L)))
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first")),
IndexWithSize.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"))))
.allMatch(d -> d.getTotalSize() >= 106_496L);

assertThat(check)
Expand Down
12 changes: 6 additions & 6 deletions ...test/java/io/github/mfvanek/pg/health/checks/cluster/UnusedIndexesCheckOnClusterTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ void onDatabaseWithThem(final String schemaName) {
.executing(ctx)
.hasSize(6)
.containsExactlyInAnyOrder(
UnusedIndex.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_number_balance_not_deleted"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number_not_deleted"), 0L, 0),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_id_account_number_not_deleted"), 0L, 0))
UnusedIndex.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_first")),
UnusedIndex.of(ctx.enrichWithSchema("clients"), ctx.enrichWithSchema("i_clients_last_name")),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number")),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_number_balance_not_deleted")),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_account_number_not_deleted")),
UnusedIndex.of(ctx.enrichWithSchema("accounts"), ctx.enrichWithSchema("i_accounts_id_account_number_not_deleted")))
.allMatch(i -> i.getIndexSizeInBytes() > 0L)
.allMatch(i -> i.getIndexScans() == 0);

Expand Down