fix: made the dataroom route protected in case user hasn't opted for any trial or plan #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…any trial or plan
|
@nidhish-srivastava is attempting to deploy a commit to the mftsio Team on Vercel. A member of the Team first needs to authorize it. |
mfts
requested changes
Sep 15, 2024
Comment on lines
+42
to
+44
| useEffect(()=>{ | ||
| if(trial == null) router.push('/documents') | ||
| },[trial]) |
There was a problem hiding this comment.
@nidhish-srivastava this might have unindented consequences.
for example it would push everyone who can view the datarooms page on a plan that supports it (business, datarooms) to be redirected to /documents because in their case trial == null is true
There was a problem hiding this comment.
Yes you are right
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution - Made a check of trial variable from usePlan() hook to see if its null or not,if its null,navigate the user back to /documents page