feat: improve typings for lighthouse
and shared
#186
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When trying to use this package in a Cypress project with TypeScript, I ran into several errors with typings. For example:
cypress
to rootpackage.json
. This will allow IDE to recognize/// <reference types="cypress" />
index.d.ts
inpackages/lighthouse
index.d.ts
inpackages/shared
types
topackage.json
for bothpackages/lighthouse
andpackages/shared
.eslintignore
to ignore.d.ts
cc @mfrachet