Repository navigation
Conversation
jsdom 30.1 no longer exposes Symbol(impl) as an own property on its wrappers. vitest's jsdom URL.createObjectURL shim looks that symbol up, finds nothing, and throws on every call, failing the banner-cache tests in #952.
Owner
Author
|
Follow-up to lift this hold: #955. Upstream bug: vitest-dev/vitest#11336, fix in vitest-dev/vitest#11353 (open). |
Owner
Author
|
Closing unmerged: we'll wait for the vitest release carrying vitest-dev/vitest#11353 instead of holding jsdom. Tracked on #952. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Holds
jsdombelow 30.1 in the/webDependabot config. This unblocks the dev-tooling group in #952.Why. jsdom 30.1 no longer exposes
Symbol(impl)as an own property on its wrappers. Vitest's jsdomURL.createObjectURLshim (createCompatUtils) finds the impl symbol throughObject.getOwnPropertyDescriptors(new window.Blob()). On 30.1 it finds nothing, soblob[implSymbol]._bufferthrows on everycreateObjectURLcall. This fails the 5Login — cached pre-auth banner (#833)tests in #952.Bisected from #952's lockfile:
new window.Blob():[Symbol(impl)]on 30.0.1,[]on 30.1.1.Upstream vitest-dev/vitest#11295 (merged 2026-09-17, not yet released) handles jsdom 28's
_buffer→_bytesrename. It does not address the missing symbol, so it will not fix this on its own.Follow-up. After this merges, comment
@dependabot recreateon #952 so the group is rebuilt without jsdom. Remove the ignore once a vitest release handles jsdom 30.1 wrappers.