Skip to content

fix(web): restore the grouped, alphabetised Help glossary (#657) - #924

Merged
mforce merged 1 commit into
mainfrom
fix/657-glossary-grouping
Sep 21, 2026
Merged

mforce merged 1 commit into
mainfrom
fix/657-glossary-grouping

Conversation

@mforce

@mforce mforce commented Sep 21, 2026

Copy link
Copy Markdown
Owner

PR #901 (4ee8b03) carried a stale helpGlossary.ts and reverted the grouped glossary from #657 (af4fe11). This restores the seven groups, translated jump navigation, active-language sorting, search folding, and sticky group headings on the redesigned Help page.

The approved #901 interactions remain unchanged: glossary entries still use the <details> accordion, and deep links still open and scroll to the target disclosure.

Tests:

  • cd web && npm run typecheck
  • cd web && npm test -- --run (3,251 passed)
  • Four mutation checks covering unknown groups, empty groups, missing group labels in each catalog, and removal of active-language sorting
  • Real-browser before/after captures at 1280×800 and 390×844, light and dark, including an active search

Closes #833

@coderabbitai

coderabbitai Bot commented Sep 21, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c162c8a0-b7f5-48f5-bd63-b6bec035c562


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mforce

mforce commented Sep 21, 2026

Copy link
Copy Markdown
Owner Author

Browser evidence from isolated cw657 stacks rebuilt from origin/main and commit 520f471.

The normal frames show the flat baseline versus seven grouped headings and jump links. The search frames use fifo; the restored page hides the jump navigation and empty groups, leaving only the matching Eggs/stock and Supplies groups. Both Playwright runs passed, with no unexpected page or console errors on the branch build.

before 1280 light

after 1280 light

before 1280 dark

after 1280 dark

before 390 light

after 390 light

before 390 dark

after 390 dark

before search 1280 light

after search 1280 light

before search 1280 dark

after search 1280 dark

before search 390 light

after search 390 light

before search 390 dark

after search 390 dark

@mforce
mforce merged commit dcd0e1b into main Sep 21, 2026
17 checks passed
@mforce
mforce deleted the fix/657-glossary-grouping branch September 21, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

web: convert Settings, Help, Login, Audit and Export to MUI

1 participant