Skip to content

test(web): use runtime-only credentials in step-up race tests - #608

Merged
mforce merged 1 commit into
mainfrom
chore/360-runtime-test-credentials
Aug 27, 2026
Merged

mforce merged 1 commit into
mainfrom
chore/360-runtime-test-credentials

Conversation

@mforce

@mforce mforce commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Summary

Verification

  • npm test -- --run src/routes/UsersPage.test.tsx -t "dismissed step-up continuations" — 6 passed
  • npm run typecheck

Follow-up to #607 and #360.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0209d6b816

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

);
openPassword();
const pendingPassword = `Aa1!${crypto.randomUUID()}`;
const pendingPassword = crypto.randomUUID();

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Use a policy-compliant pending reset password

When this test models a password-reset write that later succeeds, crypto.randomUUID() contains lowercase hexadecimal characters and hyphens but no uppercase character, while AddIdentityCore retains Identity's default uppercase requirement. A real SetUserPassword call would therefore reject this value rather than enter the deferred-success path, making the race asserted by this guard unreachable in production; generate a runtime-only value that still satisfies every password-policy class.

AGENTS.md reference: AGENTS.md:L137-L142

Useful? React with 👍 / 👎.

@mforce
mforce merged commit e2fb388 into main Aug 27, 2026
10 checks passed
@mforce
mforce deleted the chore/360-runtime-test-credentials branch August 27, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant