Fix DNS decompression bug and add descriptive exceptions #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mfontanini
reviewed
Jun 8, 2021
include/tins/exceptions.h
Outdated
| /** | ||
| * \brief Exception thrown when a DNS decompression pointer is out of bounds. | ||
| */ | ||
| class DNS_decompression_pointer_out_of_bounds : public exception_base { |
There was a problem hiding this comment.
Creating a new exception is fine for this case but we should make it derive from malformed_packet. Otherwise people catching malformed_packet when parsing a DNS packet will now be surprised that their catch no longer traps the exception after they upgrade their version of libtins.
On a side note, can you rename these so DNS is lowercase? e.g. dns_decompression_pointer_out_of_bounds. The rest of the exceptions don't capitalize any words (e.g. pdu_not_found) so we should keep names consistent.
include/tins/exceptions.h
Outdated
| */ | ||
| class DNS_decompression_pointer_out_of_bounds : public exception_base { | ||
| public: | ||
| DNS_decompression_pointer_out_of_bounds() : exception_base("DNS decompression pointer out of bounds") { } |
There was a problem hiding this comment.
nit: maybe add a colon after "decompression"? e.g. "DNS decompression: pointer out of bounds". Same for the other exception.
gaya-cohen
force-pushed
the
decompression-bug-fix
branch
2 times, most recently
from
e4ddd05 to
1650b60
Compare
mfontanini
approved these changes
Jun 9, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#443