Fix #263 - Install only the headers which are enabled. #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfontanini
reviewed
Oct 28, 2017
CMakeLists.txt
Outdated
| COMPONENT Headers | ||
| FILES_MATCHING PATTERN "*.h*" | ||
| ) | ||
| )x |
There was a problem hiding this comment.
I think this x is breaking the travis/appveyor builds
|
Thank you so much! You seem to have a typo but otherwise if it builds correctly I'll merge it. |
|
That was a clumsy typo. Must have knocked the key when committing. Corrected. |
|
Thanks, that works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Matias,
I saw you'd raised #263 - hadn't realised that was a requirement or the intended behaviour.
This PR uses the HEADERS list we'd defined previously to add the includes to the IDE, and installs those headers.
Best wishes,
Alex