Exposing More Data Field in 802.11 Header #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfontanini
reviewed
Oct 4, 2017
| @@ -164,6 +164,10 @@ void Dot11::power_mgmt(small_uint<1> new_value) { | |||
| header_.control.power_mgmt = (new_value)? 1 : 0; | |||
| } | |||
|
|
|||
| void Dot11::more_data(small_uint<1> new_value) { | |||
| header_.control.more_data = (new_value)? 1 : 0; | |||
There was a problem hiding this comment.
You should be able to just do = new_value as that is already in the range [0, 1].
There was a problem hiding this comment.
I agree. I was just keeping it consistent with the other fields like power management above.
There was a problem hiding this comment.
Oh I didn't realize that was the case. Alright, I'll merge it as it is then.
|
Thanks, I'm not sure how this one was missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added getter, setter, and tests for the more data field of the 802.11 header.