Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor key-combinations into separate class #136

Merged
merged 2 commits into from
Aug 30, 2024

Conversation

mfl28
Copy link
Owner

@mfl28 mfl28 commented Aug 30, 2024

  • Move key-combinations from inner Controller class into separate KeyCombinations class.

Closes #135.

@mfl28 mfl28 self-assigned this Aug 30, 2024
Copy link

codecov bot commented Aug 30, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 86.48%. Comparing base (3cc364b) to head (62e6679).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
.../boundingboxeditor/controller/KeyCombinations.java 92.30% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #136   +/-   ##
=========================================
  Coverage     86.48%   86.48%           
- Complexity     1498     1499    +1     
=========================================
  Files            96       97    +1     
  Lines          5986     5986           
  Branches        549      549           
=========================================
  Hits           5177     5177           
  Misses          532      532           
  Partials        277      277           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mfl28 mfl28 merged commit 76079a9 into master Aug 30, 2024
8 checks passed
@mfl28 mfl28 deleted the feature/refactor-key-combinations branch August 30, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor key-combinations
1 participant