Skip to content

Update master with changes from v2.0#4

Merged
tzanio merged 25 commits intomasterfrom
v2.0
Dec 2, 2021
Merged

Update master with changes from v2.0#4
tzanio merged 25 commits intomasterfrom
v2.0

Conversation

@tzanio
Copy link
Copy Markdown
Member

@tzanio tzanio commented Nov 6, 2021

No description provided.

@tzanio tzanio self-assigned this Nov 6, 2021
@tzanio tzanio added the minor label Nov 6, 2021
A small tweak in the build-mfem action
@tzanio
Copy link
Copy Markdown
Member Author

tzanio commented Nov 30, 2021

@pazner and @v-dobrev, I forgot about this PR... should we merge it?

@pazner
Copy link
Copy Markdown
Member

pazner commented Nov 30, 2021

Yes, I think so. I don't see any issues with it…

@tzanio tzanio merged commit ff5143d into master Dec 2, 2021
@tzanio tzanio deleted the v2.0 branch December 2, 2021 19:24
@tzanio tzanio restored the v2.0 branch December 6, 2021 03:39
@adrienbernede
Copy link
Copy Markdown
Collaborator

@tzanio @pazner @v-dobrev Let me just explain why master was behind v2.0

Repos use mfem/github-actions by pointing to a specific ref.

My beginner mistake was to have mfem initially point at mfem/github-actions@master.
The mistake became obvious when I had to change mfem CI on both mfem and mfem/github-acitons side with a change of the interface between the two: those working with an "older" MFEM would have failures in the CI.

This is why I now use numbered versions (v1.0, v2.0): each time I need to change the interface, I increase the version major, otherwise we most likely want to merge in the vX.0 branch so that all the users immediately benefit from this.

In the end, master was behind because it corresponded to the first "numbered version", a sort of v0.0. I couldn’t update it without risking to break the CI for some branches.

You did well merging everything to master as long as you are aware of the above caveat. Most like, little to now branch were impacted because they had enough time to update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants