-
Notifications
You must be signed in to change notification settings - Fork 4
Enable warning flags on Mac builds of MFEM #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
8f2cbf9
Update and rename README to README.md
tzanio 9ffdc85
Rename CONTRIBUTING to CONTRIBUTING.md
tzanio 17f31e5
Update CONTRIBUTING.md
tzanio e8d1728
Update README.md
tzanio e11ca67
Update README.md
tzanio 3113275
Merge pull request #1 from mfem/tzanio-patch-1
tzanio 45085b0
Enable the "-pedantic -Wall -Werror" flags on Mac.
v-dobrev 5efa5ee
Merge branch 'v2.0' into warnings-flags-tweak
adrienbernede 87f9e17
fix
adrienbernede File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| # Welcome to the MFEM GitHub actions repository | ||
|
|
||
| The github actions in this repo are used in several projects. | ||
|
|
||
| The projects mentioned in [README.md](README.md) are considered critical users of this repo. When introducing a change in this repo, | ||
| care should be taken to check that those will not break the CI process of the critical users. | ||
|
|
||
| The verification process is as follow: | ||
| - Create a branch with the changes in the GitHub actions. Push this branch to the GitHub repo. | ||
| - Create branches out of current master in the projects mentioned in [README.md](README.md). In those branches, point the GitHub actions to your new branch. | ||
| - Create pull requests, marked as `do-not-merge` in the projects so that CI is triggered with your new changes. | ||
| - Once working, submit a PR to the GitHub actions repo. |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| # Welcome to the MFEM GitHub actions repository | ||
|
|
||
| The goal of this repository is to gather the GitHub actions used by MFEM, projects related to MFEM, or any other project | ||
| interested in using them. Keeping these in one repo avoids duplicating and maintaining several copies of similar actions. | ||
|
|
||
| Projects using these actions: | ||
| - [mfem/mfem](https://github.com/mfem/mfem) | ||
| - [glvis/glvis](https://github.com/glvis/glvis) | ||
| - [ceed/laghos](https://github.com/ceed/laghos) | ||
| - [ceed/remhos](https://github.com/ceed/remhos) | ||
|
|
||
| Description of the actions: | ||
| - [`build-hypre`](build-hypre/action.yml) will download and build hypre with some degree of configuration, dictated by mfem typical usage. | ||
| - [`build-metis`](build-metis/action.yml) will download and build metis with some degree of configuration, dictated by mfem typical usage. | ||
| - [`build-mfem`](build-mfem/action.yml) will download and build mfem. This one has more configuration options, since we want to enable building various mfem configurations. It is also intended to build mfem both as the main project (in mfem CI) or as a dependency, in which case one can control what repo and branch to use. | ||
| - [`upload-coverage`](upload-coverage/action.yml) is a standard action to upload coverage information to codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, this is what was done in travis, my bad.
However, do we really want this for the optim target too?
Also, maybe it is a good idea to keep this on the linux target, because macos resource is limited...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it hurts to add these flags for the opt build -- at least with clang (which is the compiler on mac). With gcc (on linux) adding these flags to the
-O3flag results in more warnings (compared to no optimization flags) that can be quite different from one version of gcc to another -- that's why the warning flags are disabled on linux with opt build.Do you think adding these flags makes the compilation slower? I'd be surprised if there is any noticeable slowdown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, I think we want this on mac because it catches issues that are not caught by gcc -- I noticed the difference with Travis because in one instance (#1492), Travis failed (due to warning failures on mac) while the github actions were clean.