Skip to content

Conversation

@mfalt
Copy link
Owner

@mfalt mfalt commented Jul 26, 2017

Removes built in ConeProduct in favor of ProximalOperators SlicedSeparableSum, should benchmark before pull

@codecov-io
Copy link

codecov-io commented Jul 26, 2017

Codecov Report

Merging #2 into master will increase coverage by 2%.
The diff coverage is 94.44%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #2   +/-   ##
=======================================
+ Coverage   57.01%   59.01%   +2%     
=======================================
  Files          20       20           
  Lines         649      632   -17     
=======================================
+ Hits          370      373    +3     
+ Misses        279      259   -20
Impacted Files Coverage Δ
src/types.jl 80% <100%> (ø) ⬆️
src/FOSSolverInterface.jl 92.1% <100%> (ø) ⬆️
src/cones.jl 94.44% <90.9%> (+35.95%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f18c58...2fc51a9. Read the comment docs.

@coveralls
Copy link

coveralls commented Jul 26, 2017

Coverage Status

Coverage increased (+2.008%) to 59.019% when pulling 2fc51a9 on coneproduct into 6f18c58 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants