Skip to content

Filtering of border nodes relevant for winning during exploration #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 34 additions & 4 deletions src/constructor/mod.rs
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
pub(crate) mod queue;

use std::collections::VecDeque;
use std::collections::{HashSet, VecDeque};
use std::fmt;
use std::time::{Duration, Instant};

Expand Down Expand Up @@ -113,6 +113,8 @@ pub(crate) struct GameConstructor<A, Q> {
statuses: Vec<AtomicPropositionStatus>,
game: LabelledGame<AutomatonTreeLabel>,
queue: Q,
in_queue: HashSet<NodeIndex>,
filter: bool,
stats: ExplorationStats,
}

Expand All @@ -124,13 +126,21 @@ where
const ENV_OWNER: Player = Player::Odd;
const LEAF_OWNER: Player = Self::SYS_OWNER;

pub(crate) fn new(automaton_spec: AutomatonSpecification<A>, mut queue: Q) -> Self {
pub(crate) fn new(
automaton_spec: AutomatonSpecification<A>,
mut queue: Q,
filter: bool,
) -> Self {
let initial_label =
AutomatonTreeLabel::new(automaton_spec.automaton.initial_state(), TreeIndex::ROOT);
let mut game = LabelledGame::default();
let mut in_queue = HashSet::new();
let (initial_node, _) = game.add_border_node(initial_label);
game.set_initial_node(initial_node);
queue.push(initial_node);
if filter {
in_queue.insert(initial_node);
}

Self {
automaton: automaton_spec.automaton,
Expand All @@ -139,35 +149,51 @@ where
statuses: automaton_spec.statuses,
game,
queue,
in_queue,
filter,
stats: ExplorationStats::default(),
}
}

fn add_successor(
queue: &mut Q,
game: &mut LabelledGame<AutomatonTreeLabel>,
in_queue: &mut HashSet<NodeIndex>,
filter: bool,
node_index: NodeIndex,
label: AutomatonTreeLabel,
score_option: Option<A::EdgeLabel>,
) {
let (successor_index, new_node) = game.add_border_node(label);
game.add_edge(node_index, successor_index);
if new_node {
if new_node || (filter && !in_queue.contains(&successor_index)) {
if let Some(score) = score_option {
queue.push_scored(successor_index, score);
} else {
queue.push(successor_index);
}
if filter {
let inserted = in_queue.insert(successor_index);
assert!(inserted);
}
}
}

pub(crate) fn explore(&mut self, limit: ExplorationLimit) {
pub(crate) fn explore<F>(&mut self, limit: ExplorationLimit, filter_fn: F)
where
F: Fn(NodeIndex) -> bool,
{
let split = self.inputs.len();
let start = Instant::now();
let mut explored_states = 0;
let mut explored_edges = 0;
let mut explored_nodes = 0;
while let Some(node_index) = self.queue.pop() {
if self.filter && filter_fn(node_index) {
let removed = self.in_queue.remove(&node_index);
assert!(removed);
continue;
}
let label = self.game[node_index].label();
let state = label.automaton_state();
let tree_index = label.tree_index();
Expand All @@ -192,6 +218,8 @@ where
Self::add_successor(
&mut self.queue,
&mut self.game,
&mut self.in_queue,
self.filter,
node_index,
AutomatonTreeLabel::new(state, tree_succ_index),
None,
Expand All @@ -206,6 +234,8 @@ where
Self::add_successor(
&mut self.queue,
&mut self.game,
&mut self.in_queue,
self.filter,
node_index,
AutomatonTreeLabel::new(successor_state, TreeIndex::ROOT),
Some(edge.label().clone()),
Expand Down
4 changes: 2 additions & 2 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ fn explore_with<A: MaxEvenDpa, Q: ExplorationQueue<NodeIndex, A::EdgeLabel>>(
where
A::EdgeLabel: Clone + Eq + Ord,
{
let constructor = GameConstructor::new(automaton_spec, queue);
let constructor = GameConstructor::new(automaton_spec, queue, options.exploration_filter);

match options.parity_solver {
Solver::Fpi => solve_with(constructor, FpiSolver::new(), options),
Expand Down Expand Up @@ -287,7 +287,7 @@ where

let mut incremental_solver = IncrementalSolver::new(solver);
loop {
constructor.explore(limit);
constructor.explore(limit, |_| false);
let game = constructor.get_game();
let result = incremental_solver.solve(game);
let construction_stats = constructor.stats();
Expand Down