Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Absolute seek #46

Merged
merged 14 commits into from
Jan 27, 2021
Merged

Absolute seek #46

merged 14 commits into from
Jan 27, 2021

Conversation

karlek
Copy link
Contributor

@karlek karlek commented Jan 25, 2021 •
edited
Loading

Reference implementation for #45
Reference poc: https://github.com/karlek/catamp/tree/seek-poc

@coveralls
Copy link

coveralls commented Jan 25, 2021 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 45.234% when pulling a3a25a9 on absolute-seek into bb157a5 on master.

mewmew
mewmew reviewed Jan 25, 2021
View reviewed changes
Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a few assorted comments. (oh, and run go fmt ^^)

Continuation of #44, fixes #45.

flac.go Outdated Show resolved Hide resolved
flac.go Outdated Show resolved Hide resolved
flac.go Outdated Show resolved Hide resolved
flac.go Show resolved Hide resolved
flac.go Show resolved Hide resolved
flac.go Outdated Show resolved Hide resolved
flac.go Outdated Show resolved Hide resolved
flac_test.go Show resolved Hide resolved
frame/frame.go Outdated Show resolved Hide resolved
flac.go Show resolved Hide resolved
karlek and others added 8 commits January 26, 2021 02:05
@karlek @mewmew
Update flac.go
a8f9e2a 
Co-authored-by: Robin <mewmew@users.noreply.github.com>
@karlek @mewmew
Update flac.go
b469db7 
Co-authored-by: Robin <mewmew@users.noreply.github.com>
@karlek @mewmew
Update flac.go
32da24a 
Co-authored-by: Robin <mewmew@users.noreply.github.com>
@karlek @mewmew
Update flac.go
b2b9fb9 
Co-authored-by: Robin <mewmew@users.noreply.github.com>
@karlek @mewmew
Update flac_test.go
b60f1c9 
Co-authored-by: Robin <mewmew@users.noreply.github.com>
@karlek @mewmew
Update frame/frame.go
57578f4 
Co-authored-by: Robin <mewmew@users.noreply.github.com>
@karlek
flac: Improve code styling
c08b7c3
@karlek
flac: Add ErrNoSeeker documentation comment
0d8619c
@karlek
Copy link
Contributor Author

karlek commented Jan 26, 2021

It builds on travis: https://travis-ci.org/github/mewkiz/flac/builds/756228717

cswank
cswank reviewed Jan 26, 2021
View reviewed changes
flac.go
// Seek seeks to the frame containing the given absolute sample number. The
// return value specifies the first sample number of the frame containing
// sampleNum.
func (stream *Stream) Seek(sampleNum uint64) (uint64, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change!

flac.go Show resolved Hide resolved
mewmew
mewmew reviewed Jan 26, 2021
View reviewed changes
Copy link
Member

@mewmew mewmew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close to ready for merge. searchFromStart still needs some love, as it can reach two different panic states.

Edit: it looks like some review comments were hidden because this thread became too long. (i.e. not the resolved comments, but unresolved ones).

In particular: #46 (comment)

flac.go Outdated Show resolved Hide resolved
flac.go Show resolved Hide resolved
@karlek karlek mentioned this pull request Jan 26, 2021
Merged
mewmew
mewmew reviewed Jan 27, 2021
View reviewed changes
Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool to see the abs-seek branch being fuzzed as well!

The last change requested before merge is for searchFromStart to return prev instead of panic with unreachable. Other than that, it's just stylistic and personal preferences, so I'm fine to merge after adding return prev.

Great work @karlek and @cswank! We finally get seek support integrated into the FLAC library.

flac.go Outdated Show resolved Hide resolved
karlek and others added 2 commits January 27, 2021 23:31
@karlek @mewmew
Update flac.go
ac9185b 
Co-authored-by: Robin <mewmew@users.noreply.github.com>
@karlek @mewmew
Update flac.go
802031a 
Co-authored-by: Robin <mewmew@users.noreply.github.com>
mewmew
mewmew approved these changes Jan 27, 2021
View reviewed changes
Copy link
Member

@mewmew mewmew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mewmew mewmew merged commit 11466d8 into master Jan 27, 2021
@mewmew mewmew mentioned this pull request Jan 27, 2021
Closed
mewmew added a commit that referenced this pull request Jan 27, 2021
@mewmew
readme: update release date of v1.0.7 and add ref to #46
69bef32
@mewmew mewmew deleted the absolute-seek branch October 24, 2023 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cswank cswank cswank left review comments

@mewmew mewmew mewmew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@karlek @coveralls @cswank @mewmew