fix(fast-element): always reflect latest value to attribute (microsof…

…t#2903)
meunice · Apr 9, 2020 · 48cca59 · 48cca59
1 parent 9a6f464
commit 48cca59
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/packages/fast-element/src/attributes.ts b/packages/fast-element/src/attributes.ts
@@ -88,7 +88,7 @@ export class AttributeDefinition {
         if (oldValue !== newValue) {
             element[this.fieldName] = newValue;
 
-            this.tryReflectToAttribute(element, newValue, converter);
+            this.tryReflectToAttribute(element);
 
             if (this.hasCallback) {
                 element[this.callbackName](oldValue, newValue);
@@ -113,11 +113,7 @@ export class AttributeDefinition {
         this.guards.delete(element);
     }
 
-    private tryReflectToAttribute(
-        element: HTMLElement,
-        newValue: any,
-        converter?: ValueConverter
-    ) {
+    private tryReflectToAttribute(element: HTMLElement) {
         const mode = this.mode;
         const guards = this.guards;
 
@@ -128,16 +124,19 @@ export class AttributeDefinition {
         DOM.queueUpdate(() => {
             guards.add(element);
 
+            const latestValue = element[this.fieldName];
+
             switch (mode) {
                 case "reflect":
+                    const converter = this.converter;
                     DOM.setAttribute(
                         element,
                         this.attribute,
-                        converter !== void 0 ? converter.toView(newValue) : newValue
+                        converter !== void 0 ? converter.toView(latestValue) : latestValue
                     );
                     break;
                 case "boolean":
-                    DOM.setBooleanAttribute(element, this.attribute, newValue);
+                    DOM.setBooleanAttribute(element, this.attribute, latestValue);
                     break;
             }