Skip to content

feat: Explicit error with unsupported files #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

feat: Explicit error with unsupported files #10

wants to merge 2 commits into from
+29 −1

Conversation

@krlmlr
Copy link

@krlmlr krlmlr commented Nov 2, 2025 •
edited
Loading

For #5.

When I try to run tests, I see:

✗ make test_debug
Running DEBUG tests..
/Users/kirill/git/duckdb-read-stat/configure/venv/bin/python3: No module named duckdb_sqllogictest.__main__; 'duckdb_sqllogictest' is a package and cannot be directly executed
make: *** [test_extension_debug_internal] Error 1

Happy to add tests once I understand how to run them, perhaps also on CI/CD?

@krlmlr krlmlr mentioned this pull request Nov 8, 2025
Open
mettekou
mettekou requested changes Nov 9, 2025
View reviewed changes
src/duckdb_read_stat.c Outdated
data->file_format = DUCKDB_READ_STAT_FILE_FORMAT_STATA;
error = readstat_parse_dta(parser, path, data);
}
else if (!strcmp(format, "sas7cdat"))
Copy link
Owner

@mettekou mettekou Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krlmlr This is not the right extension for a SAS catalog file, you want sas7bcat instead.

src/duckdb_read_stat.c Outdated
}
else if (!strcmp(format, "sas7cdat"))
{
duckdb_bind_set_error(info, "SAS catalog files (.sas7cdat) are not supported. Only SAS data files (.sas7bdat, .xpt) are supported.");
Copy link
Owner

@mettekou mettekou Nov 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krlmlr The same here: you want sas7bcat instead.

src/duckdb_read_stat.c Outdated
data->file_format = DUCKDB_READ_STAT_FILE_FORMAT_STATA;
error = readstat_parse_dta(parser, path, data);
}
else if (duckdb_read_stat_ends_with(path, ".sas7cdat"))
Copy link
Owner

@mettekou mettekou Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krlmlr The same here: you want .sas7bcat instead.

src/duckdb_read_stat.c Outdated
}
else if (duckdb_read_stat_ends_with(path, ".sas7cdat"))
{
duckdb_bind_set_error(info, "SAS catalog files (.sas7cdat) are not supported. Only SAS data files (.sas7bdat, .xpt) are supported.");
Copy link
Owner

@mettekou mettekou Nov 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krlmlr The same here: you want .sas7bcat instead.

@krlmlr
Copy link
Author

krlmlr commented Nov 9, 2025

Thanks, fixed. Would you like to share advice on running the tests locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mettekou mettekou mettekou requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@krlmlr @mettekou