Fix atomicity violation in AtomicSamplingReservoir::consume #606
+3
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quantpoet
changed the title
Contributor
Author
|
@tobz Hi, Could you please review this PR at your convenience? Thank you very much. |
tobz
added
C-util
Member
|
👋🏻 Sorry about the delay. |
tobz
requested changes
Sep 24, 2025
Signed-off-by: quantpoet <quantway@outlook.com>
tobz
added
the
S-awaiting-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced separate atomic load/store operations with a single fetch_xor to eliminate
the race condition where multiple threads could read the same value and write
conflicting results. This ensures the read-modify-write operation is truly atomic
and resolves the lockbud-detected atomicity violation.