Skip to content

Comments

fix: updating readable stream#76

Open
leftieFriele wants to merge 2 commits intomainfrom
update-readable-stream
Open

fix: updating readable stream#76
leftieFriele wants to merge 2 commits intomainfrom
update-readable-stream

Conversation

@leftieFriele
Copy link
Contributor

@leftieFriele leftieFriele commented Jan 9, 2026

Updating readable stream.

Closes #27

@leftieFriele leftieFriele force-pushed the update-readable-stream branch from db70b05 to 6c1739e Compare January 9, 2026 12:36
@leftieFriele leftieFriele self-assigned this Jan 9, 2026
@leftieFriele leftieFriele requested a review from wkillerud January 9, 2026 12:43
Copy link
Contributor

@wkillerud wkillerud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this perhaps a breaking change?

@leftieFriele
Copy link
Contributor Author

The changes which where breaking in readable-stream was related to Node v18 and older, so I was thinking this would be non-breaking for this module 🤔

@wkillerud
Copy link
Contributor

It might be fine, but I'll let @trygve-lie chime in. Upgrading readable-stream, semver major for this module or no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants