Stop using URI.escape and start using URI::Parser

This fixes a part of the #322 issue.
metricfu · Nov 4, 2021 · e90fda4 · e90fda4
1 parent 1ffbcdf
commit e90fda4
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/lib/metric_fu/formatter/html.rb b/lib/metric_fu/formatter/html.rb
@@ -88,7 +88,8 @@ def open_in_browser?
       #   The directory path where the 'index.html' we want to open is
       #   stored
       def show_in_browser(dir)
-        uri = URI.join(URI.escape("file://#{dir}/"), "index.html")
+        parser = URI::Parser.new
+        uri = URI.join(parser.escape("file://#{dir}/"), "index.html")
         Launchy.open(uri) if open_in_browser?
       end
     end

diff --git a/spec/metric_fu/formatter/html_spec.rb b/spec/metric_fu/formatter/html_spec.rb
@@ -80,7 +80,8 @@ def directory(name)
       allow(MetricFu.configuration).to receive(:is_cruise_control_rb?).and_return(false)
       formatter = MetricFu::Formatter::HTML.new
       path = MetricFu.run_path.join(directory("output_directory"))
-      uri = URI.join(URI.escape("file://#{path}/"), "index.html")
+      parser = URI::Parser.new
+      uri = URI.join(parser.escape("file://#{path}/"), "index.html")
       expect(Launchy).to receive(:open).with(uri)
       formatter.finish
       formatter.display_results
@@ -125,7 +126,8 @@ def directory(name)
       allow(MetricFu.configuration).to receive(:is_cruise_control_rb?).and_return(false)
       formatter = MetricFu::Formatter::HTML.new(output: @output)
       path = MetricFu.run_path.join("#{directory('base_directory')}/#{@output}")
-      uri = URI.join(URI.escape("file://#{path}/"), "index.html")
+      parser = URI::Parser.new
+      uri = URI.join(parser.escape("file://#{path}/"), "index.html")
       expect(Launchy).to receive(:open).with(uri)
       formatter.finish
       formatter.display_results