Do not require timezone data directly for cljs #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This makes sense. Thanks!! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making a release cljs build I noticed js-joda was around 700kb and then realized the
malli.experimental.timenamespace was pulling in all historical timezone data.See the note at the bottom of the package for more info: https://www.npmjs.com/package/@js-joda/timezone
using the +/- 5 year range adds ~30kb.
This change requires ClojureScript users of malli to include the timezone data of their choice explicitly.
I had to convert the
zone-id-gento a function due toZoneIdnow not being available until runtime.