Don't lose properties when updating a key #712
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #645
Updating a key in a schema that had
{:optional true}
(or any properties) would lose those properties, and a subsequent attempt to validate against that schema without that key would fail. It appears to me (not looked at this codebase before) that this was simply because the new child was being calculated before calculating the properties.One thing I admittedly don't understand is that even before my fix the output to update looked ok:
This is why the existing tests pass, because they just check this output (I've added a test to run
validate
).But if you, say, called
malli.util/to-map-syntax
on it, you could see the properties had been lost:With this PR that is no longer the case.