Fully qualify symbols used in cljs metadata schemas #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank You. |
|
One potential issue with this PR (not sure if it's intended or not) is that predicate functions like |
|
Thanks for thoroughly testing this @kovasap I think we can check if the symbols are in cljs.core or not only qualify the ones that are not. I should have some time this weekend to look into this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures all vars used in cljs schemas are fully qualified. This is necessary because the namespace where
collect!is invoked will be the one where the generated code from the macro is produced, which likely won't have those vars available.This should fix the issue #659