Explicitly check for CharSequence in -re-schema #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-yakushev
force-pushed
the
re-find-classcast
branch
from
92bd668
to
f722146
Compare
alexander-yakushev
force-pushed
the
re-find-classcast
branch
from
f722146
to
c7bda77
Compare
|
If preferred, I can preserve the current behavior in |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current behavior attempts to run
re-findagainst any object in atry/catchblock, fails with a ClassCastException on non-charsequence objects, the exception is caught and false is returned. The drawback is that the exception object is generated and its stacktrace is filled. Besides, throwing and catching an exception in Java is not free, it follows a quite slow path compared to the tight situations the validation might be used.The profile looks like this:
