Skip to content

Use client interface in NewHTTPClientTransport #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2025
Merged

Use client interface in NewHTTPClientTransport #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion transport/http/http_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ import (
"github.com/metoro-io/mcp-golang/transport"
)

type HTTPClient interface {
Do(r *http.Request) (*http.Response, error)
}

// HTTPClientTransport implements a client-side HTTP transport for MCP
type HTTPClientTransport struct {
baseURL string
Expand All @@ -20,7 +24,7 @@ type HTTPClientTransport struct {
errorHandler func(error)
closeHandler func()
mu sync.RWMutex
client *http.Client
client HTTPClient
headers map[string]string
}

Expand All @@ -33,6 +37,12 @@ func NewHTTPClientTransport(endpoint string) *HTTPClientTransport {
}
}

// WithClient allows to set a custom HTTP client
func (t *HTTPClientTransport) WithClient(c HTTPClient) *HTTPClientTransport {
t.client = c
return t
}

// WithBaseURL sets the base URL to connect to
func (t *HTTPClientTransport) WithBaseURL(baseURL string) *HTTPClientTransport {
t.baseURL = baseURL
Expand Down