Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses metadata issues for duration subdivision plugin #2094

Merged
merged 3 commits into from
Feb 18, 2025

Conversation

bayliffe
Copy link
Contributor

@bayliffe bayliffe commented Feb 7, 2025

  • Modify duration subdivision plugin to correctly recalculate the forecast periods for the shorter periods that are created.
  • Modify the netcdf save code to explicitly exclude the inclusion of any duplicate cell methods.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

Updated acceptance test data:
metoppv/improver_test_data#74

…ast periods. Modify the netcdf save code to explicitly exclude the inclusion of any duplicate cell methods.
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.41%. Comparing base (84a8944) to head (cf9239b).
Report is 73 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2094      +/-   ##
==========================================
+ Coverage   98.39%   98.41%   +0.01%     
==========================================
  Files         124      135      +11     
  Lines       12212    13309    +1097     
==========================================
+ Hits        12016    13098    +1082     
- Misses        196      211      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…thod properties means they would not be removed as duplicates.
@brhooper brhooper self-assigned this Feb 12, 2025
brhooper
brhooper previously approved these changes Feb 13, 2025
Copy link
Contributor

@brhooper brhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bayliffe. This meets the acceptance criteria and I don't have any review comments, so happy to approve.

@brhooper brhooper removed their assignment Feb 13, 2025
@gavinevans gavinevans self-assigned this Feb 18, 2025
Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bayliffe 👍

I've just noticed one typo.

@gavinevans gavinevans assigned bayliffe and unassigned gavinevans Feb 18, 2025
Co-authored-by: gavinevans <gavin.evans@metoffice.gov.uk>
@gavinevans gavinevans merged commit 660f8f4 into metoppv:master Feb 18, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants