-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addresses metadata issues for duration subdivision plugin #2094
Conversation
…ast periods. Modify the netcdf save code to explicitly exclude the inclusion of any duplicate cell methods.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2094 +/- ##
==========================================
+ Coverage 98.39% 98.41% +0.01%
==========================================
Files 124 135 +11
Lines 12212 13309 +1097
==========================================
+ Hits 12016 13098 +1082
- Misses 196 211 +15 ☔ View full report in Codecov by Sentry. |
…thod properties means they would not be removed as duplicates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bayliffe. This meets the acceptance criteria and I don't have any review comments, so happy to approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @bayliffe 👍
I've just noticed one typo.
Co-authored-by: gavinevans <gavin.evans@metoffice.gov.uk>
Testing:
Updated acceptance test data:
metoppv/improver_test_data#74