ENH: as_iterable for improved plugin argument handling + radius_by_lead_time using it #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if this helps you out @mo-philrelton |
This did help @cpelley. I have created a PR which expands this to let the EPP workflow run. Could you merge this into your branch as I don't have the permissions to do so. I haven't added any tests for this, I can do so if you don't have the time. |
* MOBT-797: Coordinate retention in percentile generation (#2087) * Enable retention of scalar coordinates that are produced during percentile generation from coordinate collapse. This change also ensures that any scalar time coordinates that are created in this way adhere to the improver metadata standards. * style fixes. * Setting percentiles with as_iterable --------- Co-authored-by: bayliffe <benjamin.ayliffe@metoffice.gov.uk>
cpelley
changed the title
cpelley
changed the title
MoseleyS
requested changes
Jan 30, 2025
|
Looks like the changes from #2090 have been lost - probably in the rebase. |
mo-philrelton
previously approved these changes
Jan 30, 2025
Co-authored-by: Stephen Moseley <stephen.moseley@metoffice.gov.uk>
mo-philrelton
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: N/A
Description:
as_terableto improver utilities, with a similar mindset to the previously addedas_cubeandas_cubesfunctions there. This intends to improve the robustness of the plugin UI so that it does not unnecessarily require an iterable of an object when technically it should accommodate 1 of that object.as_iterablein the radius_by_lead_time.Testing:
CLA
If a new developer, signed up to CLA