Fixes in support of configuration execution which call plugins directly (i.e. not via CLI) #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpelley
commented
Oct 3, 2024
| @@ -26,25 +26,24 @@ def __init__(self, attributes: List): | |||
| self.attributes = attributes | |||
|
|
|||
| def process( | |||
| self, *cubes: Union[Cube, CubeList], template_cube: Union[Cube, CubeList] | |||
| ) -> Union[Tuple[Union[Cube, CubeList]], Cube, CubeList]: | |||
| self, *cubes: Union[Cube, CubeList]) -> Union[Cube, CubeList]: | |||
There was a problem hiding this comment.
Ideally I would define this as:
(template_cube, *cubes)
However, this would mean requiring people to swap the order of edges defined in their configurations - a cause of frustration for people migrating away from the CLI I'm sure.
cpelley
force-pushed
the
lsd_failure
branch
2 times, most recently
from
4fb713e to
be0031a
Compare
cpelley
requested review from
gavinevans,
Kat-90,
mo-robert-purvis,
brhooper and
SamGriffithsMO
cpelley
changed the title
bayliffe
approved these changes
Nov 8, 2024
MoseleyS
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Summary of changes
CopyAttributesbad arguments passing (template cube).Issues