Change to nbhood plugin to satisfy Numpy warning and future Numpy error. #1992
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bayliffe
approved these changes
May 9, 2024
| open_grid = np.array(np.ogrid[[slice(-x, x + 1) for x in (ranges, ranges)]]) | ||
| open_grid = np.array( | ||
| np.ogrid[[slice(-x, x + 1) for x in (ranges, ranges)]], dtype=object | ||
| ) |
There was a problem hiding this comment.
This looks fine, thanks for the change. I find the original syntax hard to understand. It is equivalent to:
np.array(np.ogrid[-ranges:ranges+1, -ranges:ranges+1], dtype=object)
which might have been nicer, but we don't need to change it here.
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
…or. (metoppv#1992) * Change to nbhood plugin to satisfy Numpy warning and future Numpy error. * Ran style checks. --------- Co-authored-by: Katharine Hurst <katharine.hurst@metoffice.gov.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
During the investigation work into IMPROVER wind gusts I noticed an error in our nbhood plugin when using a more up to date environment than we use for production:
ValueError: setting an array element with a sequence. The requested array has an inhomogeneous shape after 1 dimensions. The detected shape was (2,) + inhomogeneous part.It tripped me up a bit trying to work out what the problem was.
This error is a
VisibleDeprecationWarningin our current environment which explains things better:To avoid tripping up on this again in the future this PR suggests we implement the change it requires now.
Testing: