-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds CLI to copy attributes from one NetCDF file to another. #1976
Conversation
… acceptance test.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1976 +/- ##
=======================================
Coverage 98.40% 98.40%
=======================================
Files 124 124
Lines 12067 12067
=======================================
Hits 11874 11874
Misses 193 193 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small line I think needs to be deleted but otherwise I'm happy with this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MoseleyS, this looks fine.
* master: Bump actions/stale from 8 to 9 (metoppv#1972) Bump codecov/codecov-action from 3 to 4 (metoppv#1942) Bump actions/cache from 3 to 4 (metoppv#1977) Adds CLI to copy attributes from one NetCDF file to another. (metoppv#1976)
…#1976) * Adds CLI to copy attributes from one NetCDF file to another. Includes acceptance test. * Removes unused variable
Adds CLI to copy attributes from one NetCDF file to another. Includes acceptance test.
Addresses https://github.com/MetOffice/epp_workflows/pull/24
For the EPP Precipitation Type workflow, we need a new CLI to copy attribute values from one cube to another so that the precipitation type output can contain StaGE attribute values inherited from a precipitation rate cube.
Acceptance test data can be found in metoppv/improver_test_data#41
Testing: