Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds CLI to copy attributes from one NetCDF file to another. #1976

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

MoseleyS
Copy link
Contributor

Adds CLI to copy attributes from one NetCDF file to another. Includes acceptance test.

Addresses https://github.com/MetOffice/epp_workflows/pull/24

For the EPP Precipitation Type workflow, we need a new CLI to copy attribute values from one cube to another so that the precipitation type output can contain StaGE attribute values inherited from a precipitation rate cube.

Acceptance test data can be found in metoppv/improver_test_data#41

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@MoseleyS MoseleyS added the EPP PR's related to Enhancing Post Processing team label Jan 12, 2024
@MoseleyS MoseleyS assigned MoseleyS and unassigned MoseleyS Jan 12, 2024
@MoseleyS MoseleyS requested a review from mspelman07 January 12, 2024 15:50
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6f1593a) 98.40% compared to head (6232168) 98.40%.

❗ Current head 6232168 differs from pull request most recent head 5a67ecc. Consider uploading reports for the commit 5a67ecc to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1976   +/-   ##
=======================================
  Coverage   98.40%   98.40%           
=======================================
  Files         124      124           
  Lines       12067    12067           
=======================================
  Hits        11874    11874           
  Misses        193      193           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mspelman07 mspelman07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small line I think needs to be deleted but otherwise I'm happy with this.

@MoseleyS MoseleyS assigned mspelman07 and unassigned MoseleyS Jan 15, 2024
@mspelman07 mspelman07 removed their assignment Jan 15, 2024
@brhooper brhooper self-assigned this Jan 16, 2024
Copy link
Contributor

@brhooper brhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MoseleyS, this looks fine.

@brhooper brhooper merged commit b60bf10 into metoppv:master Jan 16, 2024
8 checks passed
@brhooper brhooper assigned MoseleyS and unassigned brhooper Jan 16, 2024
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Jan 22, 2024
* master:
  Bump actions/stale from 8 to 9 (metoppv#1972)
  Bump codecov/codecov-action from 3 to 4 (metoppv#1942)
  Bump actions/cache from 3 to 4 (metoppv#1977)
  Adds CLI to copy attributes from one NetCDF file to another. (metoppv#1976)
@MoseleyS MoseleyS deleted the inherit_meta branch July 19, 2024 10:29
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
…#1976)

* Adds CLI to copy attributes from one NetCDF file to another. Includes acceptance test.

* Removes unused variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPP PR's related to Enhancing Post Processing team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants