Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates checksums for threshold landmask fix #1636

Merged
merged 1 commit into from
Jan 10, 2022
Merged

Updates checksums for threshold landmask fix #1636

merged 1 commit into from
Jan 10, 2022

Conversation

MoseleyS
Copy link
Contributor

Addresses https://github.com/metoppv/mo-blue-team/issues/92

Following work on the above issue, I discovered that the threshold land-mask input file had an attribute that should be removed, so I have removed it in the branch mobt_92_threshold_landmask and this PR holds the associated checksum change.

Testing:

  • Ran tests and they passed OK

@codecov
Copy link

codecov bot commented Dec 23, 2021

Codecov Report

Merging #1636 (f7a05b7) into master (b2da263) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1636   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files         110      110           
  Lines       10079    10079           
=======================================
  Hits         9888     9888           
  Misses        191      191

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2da263...f7a05b7. Read the comment docs.

Kat-90
Kat-90 approved these changes Jan 7, 2022
View reviewed changes
Copy link
Contributor

@Kat-90 Kat-90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes, run tests and checked the resulting cube which shows the um_version attribute has been removed.
Happy to approve

@Kat-90
Copy link
Contributor

Kat-90 commented Jan 7, 2022

Also, in case it's worth noting, the CF version has also updated from 1.5 to 1.7.

@Kat-90 Kat-90 removed their assignment Jan 7, 2022
@bayliffe bayliffe self-assigned this Jan 10, 2022
@bayliffe bayliffe merged commit ebf77fe into metoppv:master Jan 10, 2022
@MoseleyS MoseleyS deleted the mobt_92_threshold_landmask branch January 10, 2022 16:09
@MoseleyS MoseleyS assigned MoseleyS and unassigned bayliffe Jan 10, 2022
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Jan 17, 2022
@MoseleyS
Merge branch 'master' into mobt_92_wxcode_mode
818e0f4 
* master:
  Remove __repr__ methods from all neighbourhood plugins (metoppv#1648)
  ENH: Avoiding lazy loading in select command calls (metoppv#1617)
  MOBT-180: Weather symbol speed up (metoppv#1638)
  IM-1621: Make ECC error and warning tests more rigorous (metoppv#1641)
  Make flake8 report that it is okay when running improver-tests. (metoppv#1645)
  Update checksums after updating the title of files in apply-emos-coefficients/sites. (metoppv#1640)
  Fixes bug in spot-extraction for multi-time inputs (metoppv#1633)
  Updates checksums for threshold landmask fix (metoppv#1636)
  Update interpret-metadata (metoppv#1632)
MoseleyS added a commit that referenced this pull request Jan 18, 2022
@MoseleyS
Merge branch 'master' into hotfix_branch_1.0.3
6b37139 
* master:
  Remove __repr__ methods from all neighbourhood plugins (#1648)
  ENH: Avoiding lazy loading in select command calls (#1617)
  MOBT-180: Weather symbol speed up (#1638)
  IM-1621: Make ECC error and warning tests more rigorous (#1641)
  Make flake8 report that it is okay when running improver-tests. (#1645)
  Update checksums after updating the title of files in apply-emos-coefficients/sites. (#1640)
  Fixes bug in spot-extraction for multi-time inputs (#1633)
  Updates checksums for threshold landmask fix (#1636)
  Update interpret-metadata (#1632)
  Weather code tree update (#1635)
  Fix noise in precip accumulation thresholds (#1627)
  Expanding on triangle time blending doc strings. (#1630)
  Better handling and documentation of dependencies (#1589)
  Add tests (#1626)
  Enhancements on new regridding code (#1560)
  Speed up interpolation in ensemble_copula_coupling.ConvertProbabilitiesToPercentiles (#1578)
  Speed up interpolation in ensemble_copula_coupling.ResamplePercentiles (#1548)
  Spot-extraction additional coordinates ordering fix (#1610)
MoseleyS added a commit that referenced this pull request Jan 18, 2022
@MoseleyS
Merge remote-tracking branch 'upstream/master' into hotfix_branch_1.0.3
040aca9 
* upstream/master:
  Remove __repr__ methods from all neighbourhood plugins (#1648)
  ENH: Avoiding lazy loading in select command calls (#1617)
  MOBT-180: Weather symbol speed up (#1638)
  IM-1621: Make ECC error and warning tests more rigorous (#1641)
  Make flake8 report that it is okay when running improver-tests. (#1645)
  Update checksums after updating the title of files in apply-emos-coefficients/sites. (#1640)
  Fixes bug in spot-extraction for multi-time inputs (#1633)
  Updates checksums for threshold landmask fix (#1636)
  Update interpret-metadata (#1632)
  Weather code tree update (#1635)
  Fix noise in precip accumulation thresholds (#1627)
  Expanding on triangle time blending doc strings. (#1630)
  Better handling and documentation of dependencies (#1589)
  Add tests (#1626)
  Enhancements on new regridding code (#1560)
  Speed up interpolation in ensemble_copula_coupling.ConvertProbabilitiesToPercentiles (#1578)
  Speed up interpolation in ensemble_copula_coupling.ResamplePercentiles (#1548)
  Spot-extraction additional coordinates ordering fix (#1610)
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Jan 21, 2022
@MoseleyS
Merge branch 'master' into mobt_161_wxcode_tree_check
59faf7d 
* master:
  MOBT-199: mosg__model_run in metadata interpreter (metoppv#1644)
  Minor correction of docstring listing truth dataframe columns (metoppv#1643)
  Remove __repr__ methods from all neighbourhood plugins (metoppv#1648)
  ENH: Avoiding lazy loading in select command calls (metoppv#1617)
  MOBT-180: Weather symbol speed up (metoppv#1638)
  IM-1621: Make ECC error and warning tests more rigorous (metoppv#1641)
  Make flake8 report that it is okay when running improver-tests. (metoppv#1645)
  Update checksums after updating the title of files in apply-emos-coefficients/sites. (metoppv#1640)
  Fixes bug in spot-extraction for multi-time inputs (metoppv#1633)
  Updates checksums for threshold landmask fix (metoppv#1636)
  Update interpret-metadata (metoppv#1632)
  Weather code tree update (metoppv#1635)
  Fix noise in precip accumulation thresholds (metoppv#1627)

# Conflicts:
#	improver_tests/acceptance/SHA256SUMS
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
@MoseleyS
Updates checksums for threshold landmask fix (metoppv#1636)
23d1dec
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
@MoseleyS
Merge remote-tracking branch 'upstream/master' into hotfix_branch_1.0.3
c9d4bb5 
* upstream/master:
  Remove __repr__ methods from all neighbourhood plugins (metoppv#1648)
  ENH: Avoiding lazy loading in select command calls (metoppv#1617)
  MOBT-180: Weather symbol speed up (metoppv#1638)
  IM-1621: Make ECC error and warning tests more rigorous (metoppv#1641)
  Make flake8 report that it is okay when running improver-tests. (metoppv#1645)
  Update checksums after updating the title of files in apply-emos-coefficients/sites. (metoppv#1640)
  Fixes bug in spot-extraction for multi-time inputs (metoppv#1633)
  Updates checksums for threshold landmask fix (metoppv#1636)
  Update interpret-metadata (metoppv#1632)
  Weather code tree update (metoppv#1635)
  Fix noise in precip accumulation thresholds (metoppv#1627)
  Expanding on triangle time blending doc strings. (metoppv#1630)
  Better handling and documentation of dependencies (metoppv#1589)
  Add tests (metoppv#1626)
  Enhancements on new regridding code (metoppv#1560)
  Speed up interpolation in ensemble_copula_coupling.ConvertProbabilitiesToPercentiles (metoppv#1578)
  Speed up interpolation in ensemble_copula_coupling.ResamplePercentiles (metoppv#1548)
  Spot-extraction additional coordinates ordering fix (metoppv#1610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bayliffe bayliffe bayliffe approved these changes

@Kat-90 Kat-90 Kat-90 approved these changes

Assignees

@MoseleyS MoseleyS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoseleyS @Kat-90 @bayliffe