Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves position of land-sea-mask in threshold CLI #1565

Merged
merged 2 commits into from
Sep 27, 2021

Conversation

MoseleyS
Copy link
Contributor

Moves position of land-sea-mask in threshold CLI to be positional so that the suite can supply it as a node.

Addresses #1518

The suite now supplies ancillary files in the list of input cubes. Therefore, this must be a positional argument, not a keyword argument.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@MoseleyS MoseleyS added this to the 1.0.0 milestone Sep 23, 2021
@MoseleyS MoseleyS self-assigned this Sep 23, 2021
@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

Merging #1565 (278e093) into master (30d2177) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1565   +/-   ##
=======================================
  Coverage   97.94%   97.94%           
=======================================
  Files         106      106           
  Lines        9478     9478           
=======================================
  Hits         9283     9283           
  Misses        195      195           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30d2177...278e093. Read the comment docs.

Copy link
Contributor

@gavinevans gavinevans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MoseleyS

This looks fine to me.

@MoseleyS MoseleyS removed their assignment Sep 24, 2021
Copy link
Contributor

@Kat-90 Kat-90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out branch and ran tests which all passed.
Checked code, all looks good for new ancillary functionality.

@MoseleyS MoseleyS merged commit 6310ed4 into metoppv:master Sep 27, 2021
@MoseleyS MoseleyS deleted the 1518_fix_vicinity_mask branch September 27, 2021 08:06
@MoseleyS
Copy link
Contributor Author

Acceptance test data did not change.

MoseleyS added a commit to MoseleyS/improver that referenced this pull request Oct 5, 2021
* bayliffe/mobt77:
  Review changes. Acceptance test added.
  Add type-hinting throughout.
  Formatting.
  Adding unit tests.
  Grouping solution and rename.
  First draft of a modal symbol plugin.
  Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data (metoppv#1568)
  Moves position of land-sea-mask in threshold CLI (metoppv#1565)
  Re-label a diagnostic as a period diagnostic (metoppv#1561)
  Adds LatitudeThreshold plugin and lightning-filter CLI (metoppv#1550)
  Adds land-mask option to threshold CLI (metoppv#1559)
  Move statsmodels in environment yml files (metoppv#1556)
  rearranged args (metoppv#1558)
  Update Code-Style-Guide.rst (metoppv#1554)
  Updating timezone cli call (metoppv#1551)
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
* Moves position of land-sea-mask in threshold CLI to be positional so that suite can supply it as a node.

* Flake8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants