-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moves position of land-sea-mask in threshold CLI #1565
Conversation
…that suite can supply it as a node.
Codecov Report
@@ Coverage Diff @@
## master #1565 +/- ##
=======================================
Coverage 97.94% 97.94%
=======================================
Files 106 106
Lines 9478 9478
=======================================
Hits 9283 9283
Misses 195 195 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MoseleyS
This looks fine to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checked out branch and ran tests which all passed.
Checked code, all looks good for new ancillary functionality.
Acceptance test data did not change. |
* bayliffe/mobt77: Review changes. Acceptance test added. Add type-hinting throughout. Formatting. Adding unit tests. Grouping solution and rename. First draft of a modal symbol plugin. Modifies LightningFromCapePrecip plugin to accept 3h precipitation-rate-max data (metoppv#1568) Moves position of land-sea-mask in threshold CLI (metoppv#1565) Re-label a diagnostic as a period diagnostic (metoppv#1561) Adds LatitudeThreshold plugin and lightning-filter CLI (metoppv#1550) Adds land-mask option to threshold CLI (metoppv#1559) Move statsmodels in environment yml files (metoppv#1556) rearranged args (metoppv#1558) Update Code-Style-Guide.rst (metoppv#1554) Updating timezone cli call (metoppv#1551)
* Moves position of land-sea-mask in threshold CLI to be positional so that suite can supply it as a node. * Flake8
Moves position of land-sea-mask in threshold CLI to be positional so that the suite can supply it as a node.
Addresses #1518
The suite now supplies ancillary files in the list of input cubes. Therefore, this must be a positional argument, not a keyword argument.
Testing: