Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes checksums for PNGs that should never have been added. #1399

Merged
merged 1 commit into from
Dec 22, 2020

Conversation

MoseleyS
Copy link
Contributor

IMPRO-1945 (#1390) included PNG files in the acceptance test directory. These have been manually removed, but are still present in the list of checksums causing the tests to fail on master. This ticket updates the checksums to remove these two PNG files.

Testing:

  • Ran tests and they passed OK

@MoseleyS MoseleyS self-assigned this Dec 22, 2020
@codecov
Copy link

codecov bot commented Dec 22, 2020

Codecov Report

Merging #1399 (b90cc32) into master (9317703) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1399   +/-   ##
=======================================
  Coverage   96.35%   96.36%           
=======================================
  Files          89       89           
  Lines        7600     7614   +14     
=======================================
+ Hits         7323     7337   +14     
  Misses        277      277           
Impacted Files Coverage Δ
improver/blending/weighted_blend.py 100.00% <0.00%> (ø)
improver/metadata/forecast_times.py 100.00% <0.00%> (ø)
improver/metadata/constants/mo_attributes.py 100.00% <0.00%> (ø)
improver/blending/calculate_weights_and_blend.py 98.61% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9317703...b90cc32. Read the comment docs.

Copy link
Contributor

@cgsandford cgsandford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - please go ahead and merge.

@MoseleyS MoseleyS merged commit 59b1a68 into metoppv:master Dec 22, 2020
@MoseleyS MoseleyS deleted the update_checksums branch December 22, 2020 08:50
MoseleyS added a commit to MoseleyS/improver that referenced this pull request Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants