Reduces code complexity in one part of weather_symbols.py. #1391
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1391 +/- ##
==========================================
- Coverage 96.34% 96.34% -0.01%
==========================================
Files 89 89
Lines 7579 7578 -1
==========================================
- Hits 7302 7301 -1
Misses 277 277
Continue to review full report at Codecov.
|
| ">=": "<", | ||
| ">": "<=", | ||
| "OR": "AND", | ||
| "": "", |
There was a problem hiding this comment.
The simpler conditions don't have a comparator (AND and OR), so we need the ability to return an empty string too. This could be an if test in the calling function instead.
| """Test that the _invert_comparator method raises an error when the condition | ||
| cannot be inverted.""" | ||
| plugin = WeatherSymbols() | ||
| possible_inputs = ["==", "!=", "NOT", "XOR"] |
There was a problem hiding this comment.
Hmm - but you could have any of these conditions in your dictionary. (Although the test is valid.)
There was a problem hiding this comment.
My thinking is that if we add any of these to that dictionary, then this test will force us to update the unit-tests. Codecov does not check that every entry in a dictionary is touched, only that every line of code is touched.
) * Reduces code complexity in one part of weather_symbols.py. * Refactors the dict definition so it is only performed once. * Adds unit test for new error message. * Removes == from list of invertible conditions, as it was wrong and isn't used anyway. * Proves == raises the error too * Improves doc-string
In an attempt to apply some Python training, I've refactored the "invert_condition" function in WeatherSymbols to remove an if..elif..elif..elif block. The code will no longer allow unrecognised comparators rather than returning them unchanged.
Testing: