Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pydantic warning #1573

Merged
merged 2 commits into from
Mar 31, 2025
Merged

fix: Pydantic warning #1573

merged 2 commits into from
Mar 31, 2025

Conversation

thorbjoernl
Copy link
Collaborator

@thorbjoernl thorbjoernl commented Mar 31, 2025

Change Summary

Fixes the underlying pydantic issue. Unsilences the related deprecation warning.

Related issue number

closes #1564

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Mar 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.24%. Comparing base (6e3fe5a) to head (7b0c130).
Report is 6 commits behind head on main-dev.

Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1573   +/-   ##
=========================================
  Coverage     77.24%   77.24%           
=========================================
  Files           145      145           
  Lines         21280    21280           
=========================================
  Hits          16437    16437           
  Misses         4843     4843           
Flag Coverage Δ
unittests 77.24% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@thorbjoernl thorbjoernl added this to the m2025-04 milestone Mar 31, 2025
@thorbjoernl thorbjoernl requested a review from lewisblake March 31, 2025 07:40
@thorbjoernl thorbjoernl marked this pull request as ready for review March 31, 2025 07:41
@lewisblake lewisblake merged commit 13cc6c4 into main-dev Mar 31, 2025
8 checks passed
@lewisblake lewisblake deleted the uncap-pydantic branch March 31, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pydantic >= 2.11
2 participants