-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Colocated data from Mines Paris + solar irradiance variables #1559
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main-dev #1559 +/- ##
============================================
- Coverage 77.43% 77.24% -0.20%
============================================
Files 138 145 +7
Lines 20860 21280 +420
============================================
+ Hits 16153 16437 +284
- Misses 4707 4843 +136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d9bd070
to
be93ba1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the test still failing or is that out of date? Otherwise looks good
Looks like only code coverage is failing, which we don't reach because this PR mostly just adds variables, which isn't really something we test. |
I was refering to "tests/aeroval/test_bulkfraction_engine.py:215 test_run_cfg is failing" in the PR body |
I see. Yes, this test is now passing locally. I will update the comment above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Introduce
BNI
,DHI
, andGHI
solar irradiance variables, their web display options, and a newCategoryType
inglobal_defaults.py
for solar irradiance. Used in experiments to evaluate renewable energy production models.Related issue number
NA
Checklist