Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colocated data from Mines Paris + solar irradiance variables #1559

Merged
merged 3 commits into from
Mar 27, 2025

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Mar 26, 2025

Change Summary

Introduce BNI, DHI, and GHI solar irradiance variables, their web display options, and a new CategoryType in global_defaults.py for solar irradiance. Used in experiments to evaluate renewable energy production models.

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.24%. Comparing base (aa4be39) to head (be93ba1).
Report is 84 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1559      +/-   ##
============================================
- Coverage     77.43%   77.24%   -0.20%     
============================================
  Files           138      145       +7     
  Lines         20860    21280     +420     
============================================
+ Hits          16153    16437     +284     
- Misses         4707     4843     +136     
Flag Coverage Δ
unittests 77.24% <100.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lewisblake lewisblake requested a review from thorbjoernl March 26, 2025 15:18
@lewisblake lewisblake added this to the m2025-04 milestone Mar 26, 2025
@lewisblake lewisblake added the new-obs New observational dataset label Mar 26, 2025
@lewisblake lewisblake marked this pull request as ready for review March 26, 2025 15:22
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the test still failing or is that out of date? Otherwise looks good

@lewisblake
Copy link
Member Author

Looks like only code coverage is failing, which we don't reach because this PR mostly just adds variables, which isn't really something we test.

@thorbjoernl
Copy link
Collaborator

I was refering to "tests/aeroval/test_bulkfraction_engine.py:215 test_run_cfg is failing" in the PR body

@lewisblake
Copy link
Member Author

I see. Yes, this test is now passing locally. I will update the comment above.

Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lewisblake lewisblake merged commit e392ae4 into main-dev Mar 27, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-obs New observational dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants