Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable caching for pyaro based datasets #1535

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

jgriesfeller
Copy link
Member

@jgriesfeller jgriesfeller commented Mar 3, 2025

Change Summary

The subject says it all

Related issue number

fix #1532

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@jgriesfeller jgriesfeller self-assigned this Mar 3, 2025
@jgriesfeller jgriesfeller linked an issue Mar 3, 2025 that may be closed by this pull request
@jgriesfeller jgriesfeller added the obs-update Update related to existing observation dataset label Mar 3, 2025
@jgriesfeller jgriesfeller added this to the m2025-04 milestone Mar 3, 2025
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.24%. Comparing base (2c68b0f) to head (eaa4153).
Report is 8 commits behind head on main-dev.

Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1535      +/-   ##
============================================
+ Coverage     78.23%   78.24%   +0.01%     
============================================
  Files           145      145              
  Lines         21643    21645       +2     
============================================
+ Hits          16932    16936       +4     
+ Misses         4711     4709       -2     
Flag Coverage Δ
unittests 78.24% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jgriesfeller jgriesfeller requested a review from magnusuMET March 3, 2025 14:59
@jgriesfeller jgriesfeller marked this pull request as ready for review March 3, 2025 14:59
@lewisblake lewisblake merged commit 2d087a4 into main-dev Mar 4, 2025
8 checks passed
@magnusuMET magnusuMET deleted the 1532-caching-pyaro-datasets-bug-or-feature branch March 4, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
obs-update Update related to existing observation dataset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching pyaro datasets: Bug or feature?
3 participants