Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for move of overlay out of contour #1524

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Conversation

lewisblake
Copy link
Member

@lewisblake lewisblake commented Feb 19, 2025

Change Summary

countour/overlay -> overlay mean that a lot of the logic needed modify, especially in the only_model_maps case. These are fixes which seem to work, but more testing is needed to see how this interacts when there are both contour and and overlay plots

Related issue number

NA

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.96%. Comparing base (c52cd91) to head (d5bdd98).
Report is 43 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aeroval/experiment_output.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main-dev    #1524   +/-   ##
=========================================
  Coverage     77.95%   77.96%           
=========================================
  Files           144      144           
  Lines         21563    21568    +5     
=========================================
+ Hits          16810    16815    +5     
  Misses         4753     4753           
Flag Coverage Δ
unittests 77.96% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lewisblake lewisblake added this to the m2025-03 milestone Feb 19, 2025
@lewisblake lewisblake added the bug 🐛 Something isn't working label Feb 19, 2025
@lewisblake lewisblake self-assigned this Feb 19, 2025
Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status of the local tests?

@lewisblake
Copy link
Member Author

What's the status of the local tests?

Still failing. I'll come talk to you tomorrow

Copy link
Collaborator

@thorbjoernl thorbjoernl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

I ran the tests locally, and they seem to pass now. 🧪

@lewisblake lewisblake marked this pull request as ready for review February 25, 2025 12:38
@lewisblake lewisblake merged commit 8bb1db8 into main-dev Feb 25, 2025
7 of 8 checks passed
@thorbjoernl thorbjoernl deleted the thanos_his_res_testing branch February 25, 2025 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants